-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add GPU runner for linux-aarch64 #289
Conversation
Auto-sync is disabled for ready for review pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
/ok to test |
/ok to test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems legit so long as we get the runner issues sorted, and rerun the CI before submission in case the problem spans multiple runner platforms
/ok to test |
/ok to test |
It seems on aarch64 we hit this issue... actions/setup-python#961 |
/ok to test |
/ok to test |
/ok to test |
/ok to test |
/ok to test |
image: condaforge/miniforge3:latest | ||
image: ubuntu:22.04 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
setup-python
is being very restrictive, as it purposely locks in to Ubuntu:
- Support non-ubuntu linux distributions by specify location of versions-manifest.json actions/setup-python#716
- Supported python version not found on self-hosted runner actions/setup-python#961
(And for some reason, the miniforge3
container can still work w/ setup-python
on linux-64 but not on linux-aarch64...)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We added ARM support earlier this year: conda-incubator/setup-miniconda#331
So when you have a moment, could you please raise the Miniforge GHA specific issue
Edit: Or perhaps this is as simple as switching to conda-incubator/setup-miniconda
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If the question is "why don't you use conda to set up a Python environment?" the answer is it's on our TODO list: #280. Contribution is more than welcome 😉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just saw the issue flagged above and tried to help convert this into an upstream issue or provide a path forward
All runners are green, let me merge. |
No description provided.